Allow reading/writing text envelopes from pipes #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvikGalois
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
LudvikGalois
force-pushed
the
ludvikgalois/support-pipes-in-transaction
branch
from
1ba57d6
to
ec5063c
Compare
Previously the functions to read text envelopes used `readFile` from Data.ByteString. Unfortunately, that doesn't work with pipes, so we've switched to a function that does. Additionally, on unix based systems, we've changed how writing to an owned file works. Previously a new file was created (and since we created it, we must own it) and then copied into place. Unfortunately this doesn't work with symlinks, fifos, unix sockets or anything else that isn't a "normal" file. What we do now is grab the file descriptor, call fchown on it, which sets us as the owner (or errors out if we can't do that), and then write to the file.
LudvikGalois
force-pushed
the
ludvikgalois/support-pipes-in-transaction
branch
from
ec5063c
to
e8c5317
Compare
Jimbo4350
approved these changes
Aug 29, 2022
| bracketOnError | ||
| (openFd path WriteOnly (Just ownerModes) defaultFileFlags) | ||
| closeFd | ||
| (\fd -> setFdOwnerAndGroup fd user (-1) >> pure fd) |
There was a problem hiding this comment.
Why -1 for the group id?
There was a problem hiding this comment.
setFdOwnerAndGroup is a thin wrapper over fchown, and has kept the behaviour of the original (-1 for "do not change") instead of changing the type to be a more idiomatic Haskell Maybe Int.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the functions to read text envelopes used
readFilefromData.ByteString. Unfortunately, that doesn't work with pipes, so we've
switched to a function that does.
Additionally, on unix based systems, we've changed how writing to an
owned file works. Previously a new file was created (and since we
created it, we must own it) and then copied into place. Unfortunately
this doesn't work with symlinks, fifos, unix sockets or anything else
that isn't a "normal" file. What we do now is grab the file descriptor,
call fchown on it, which sets us as the owner (or errors out if we can't
do that), and then write to the file.
Fixes #4235